Fix docs dependency resolution#1245
Merged
Merged
Conversation
a1cac32 to
02ee3bd
Compare
02ee3bd to
65e95ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manifoldscompat to0.11, resolving theRecursiveArrayTools 4.xconflict from issue Docs dependency install is unsatisfiable on master #1244OptimizationSpeedMappingcompat toSpeedMapping 0.4, which is needed by the currentNonlinearSolve/SciMLBasedocs stackSpeedMapping 0.4result API by mapping the newstatusfield to SciMLBase return codesImplementation Notes
Reproduced the docs resolver failure first. Moving
Manifoldsto0.11exposed the next resolver blocker inOptimizationSpeedMapping, becauseSpeedMapping 0.3restrictsNonlinearSolvetoo tightly for the current SciML stack. After moving toSpeedMapping 0.4, the package test exposed thatSpeedMappingResultnow reportsstatusinstead ofconverged, so this PR maps:first_order,:max_time,:max_iter,:max_eval, and:failureto SciMLBase return codes.Verification
julia -e 'using JuliaFormatter; format("docs/Project.toml"); format("lib/OptimizationSpeedMapping/Project.toml"); format("lib/OptimizationSpeedMapping/src/OptimizationSpeedMapping.jl"); format("lib/OptimizationSpeedMapping/test/core_tests.jl")'julia -e 'using Runic; for file in ARGS; Runic.format_file(file; inplace=true); end' lib/OptimizationSpeedMapping/src/OptimizationSpeedMapping.jl lib/OptimizationSpeedMapping/test/core_tests.jljulia --project=docs -e 'using Pkg; Pkg.instantiate()'julia --project=lib/OptimizationSpeedMapping -e 'using Pkg; Pkg.test()'julia --project=lib/OptimizationManopt -e 'using Pkg; Pkg.test()'julia --project=docs -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate()'Closes #1244.